Github user superbobry commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21180#discussion_r184860643
  
    --- Diff: python/pyspark/serializers.py ---
    @@ -523,7 +523,21 @@ def namedtuple(*args, **kwargs):
             for k, v in _old_namedtuple_kwdefaults.items():
                 kwargs[k] = kwargs.get(k, v)
             cls = _old_namedtuple(*args, **kwargs)
    -        return _hack_namedtuple(cls)
    +
    +        import sys
    +        f = sys._getframe(1)
    --- End diff --
    
    Good point. 
[`collections.nametuple`](https://github.com/python/cpython/blob/master/Lib/collections/__init__.py#L466)
 has a fix for Jython and IronPython. I can backport it for completeness, but 
realistically, the probability of someone running PySpark on these 
implementations is not very high.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to