Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20937#discussion_r184870234
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
 ---
    @@ -175,11 +187,18 @@ object MultiLineJsonDataSource extends JsonDataSource 
{
           .values
       }
     
    -  private def createParser(jsonFactory: JsonFactory, record: 
PortableDataStream): JsonParser = {
    -    val path = new Path(record.getPath())
    -    CreateJacksonParser.inputStream(
    -      jsonFactory,
    -      
CodecStreams.createInputStreamWithCloseResource(record.getConfiguration, path))
    +  private def dataToInputStream(dataStream: PortableDataStream): 
InputStream = {
    +    val path = new Path(dataStream.getPath())
    +    
CodecStreams.createInputStreamWithCloseResource(dataStream.getConfiguration, 
path)
    +  }
    +
    +  private def createParser(jsonFactory: JsonFactory, stream: 
PortableDataStream): JsonParser = {
    +    CreateJacksonParser.inputStream(jsonFactory, dataToInputStream(stream))
    +  }
    +
    +  private def createParser(enc: String, jsonFactory: JsonFactory,
    +      stream: PortableDataStream): JsonParser = {
    --- End diff --
    
    ditto for style


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to