Github user bersprockets commented on a diff in the pull request:
https://github.com/apache/spark/pull/21169#discussion_r185057781
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1208,6 +1208,13 @@ object SQLConf {
.stringConf
.createWithDefault("")
+ val REJECT_TIMEZONE_IN_STRING =
buildConf("spark.sql.function.rejectTimezoneInString")
+ .internal()
+ .doc("If true, `to_utc_timestamp` and `from_utc_timestamp` return null
if the input string " +
+ "contains a timezone part, e.g. `2000-10-10 00:00:00+00:00`.")
+ .booleanConf
+ .createWithDefault(true)
+
--- End diff --
>existing workloads may depend on the previous behavior and think that's
corrected
Then I think we need test cases (maybe in DateFunctionsSuite, since those
tests would also exercise the type coercion), where REJECT_TIMEZONE_IN_STRING
is false.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
