Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21173#discussion_r185373655
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala 
---
    @@ -1190,4 +1190,20 @@ class JDBCSuite extends SparkFunSuite
           assert(sql("select * from people_view").schema === schema)
         }
       }
    +
    +  test("SPARK-23856 Spark jdbc setQueryTimeout option") {
    +    val numJoins = 100
    +    val longRunningQuery =
    --- End diff --
    
    ok, I'll add tests for that.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to