Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21211#discussion_r185397554
  
    --- Diff: python/pyspark/tests.py ---
    @@ -2303,6 +2303,15 @@ def test_py4j_exception_message(self):
     
             self.assertTrue('NullPointerException' in 
_exception_message(context.exception))
     
    +    def test_parsing_version_string(self):
    +        from pyspark.util import VersionUtils
    +
    +        (major, minor) = VersionUtils.majorMinorVersion("2.4.0")
    --- End diff --
    
    I think we don't need this since it's tested in doctests.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to