Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21054#discussion_r185400649 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala --- @@ -686,4 +687,72 @@ class DataFrameAggregateSuite extends QueryTest with SharedSQLContext { } } } + --- End diff -- We need to add tests in `sql/core/src/test/resources/sql-tests` for testing via the spark sql parser, too?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org