Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/21178#discussion_r185423072
--- Diff:
sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/HiveAuthFactory.java
---
@@ -92,7 +95,26 @@ public String getAuthName() {
public static final String HS2_PROXY_USER = "hive.server2.proxy.user";
public static final String HS2_CLIENT_TOKEN = "hiveserver2ClientToken";
- public HiveAuthFactory(HiveConf conf) throws TTransportException {
+ private static Field keytabFile = null;
+ private static Method getKeytab = null;
+ static {
+ Class<?> clz = UserGroupInformation.class;
+ try {
+ keytabFile = clz.getDeclaredField("keytabFile");
+ keytabFile.setAccessible(true);
+ } catch (NoSuchFieldException nfe) {
+ keytabFile = null;
--- End diff --
I am not sure what you mean by that statement.
```
$ $ find sql/hive-thriftserver/ -type f | grep scala$ | xargs grep -i
'log.*"' | wc -l
42
```
Log messages help us debug issues without needing to modify code; and this
is an excellent case of where logging at appropriate level will help us unearth
issues in production.
I am not sure what the concern here is.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
