Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21206#discussion_r185489656
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java
---
@@ -92,17 +92,22 @@ public void reserve(int requiredCapacity) {
} else {
throwUnsupportedException(requiredCapacity, null);
}
+ } else if (requiredCapacity < 0) {
--- End diff --
Although this should work for most cases, is it still possible that the
overflowed value can be between `capacity` and `MAX_CAPACITY` ? I know it
should be quite rare corner case but just want to point it out whether we care
about that.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
