GitHub user bersprockets opened a pull request:

    https://github.com/apache/spark/pull/21231

    [SPARK-24119][SQL]Add interpreted execution to SortPrefix expression

    ## What changes were proposed in this pull request?
    
    Implemented eval in SortPrefix expression.
    
    ## How was this patch tested?
    
    - ran existing sbt SQL tests
    - added unit test
    - ran existing Python SQL tests
    - manual tests: disabling codegen -- patching code to disable beyond what 
spark.sql.codegen.wholeStage=false can do -- and running sbt SQL tests


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bersprockets/spark sortprefixeval

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21231.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21231
    
----
commit 280b941a1adc2ffcd82810a69f3d9e475607b70a
Author: Bruce Robbins <bersprockets@...>
Date:   2018-04-28T23:26:48Z

    Checkpoint changes

commit 4a810ae8776893ba1d12e620930473fdd61d1f49
Author: Bruce Robbins <bersprockets@...>
Date:   2018-04-29T18:25:26Z

    Checkpoint commit

commit d1a7e220040ba1cfe4facb7d6eef9ae1251768aa
Author: Bruce Robbins <bersprockets@...>
Date:   2018-04-29T19:19:37Z

    Checkpoint commit

commit 4dbb0b7ae959a6a4f85122a887bab4e1563255f0
Author: Bruce Robbins <bersprockets@...>
Date:   2018-04-29T22:33:21Z

    Comment on testing oddity

commit 227b6ac71bcfe6a54051f47dd16aec047b0a98d9
Author: Bruce Robbins <bersprockets@...>
Date:   2018-04-30T21:22:09Z

    Add boolean test for Sortprefix

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to