Github user aditkumar commented on the issue:
https://github.com/apache/spark/pull/20787
Not at all
On Thu, May 3, 2018 at 9:30 PM Hyukjin Kwon <notificati...@github.com>
wrote:
> *@HyukjinKwon* commented on this pull request.
> ------------------------------
>
> In
>
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
> <https://github.com/apache/spark/pull/20787#discussion_r185976200>:
>
> > @@ -887,11 +887,25 @@ object DateTimeUtils {
> * Returns number of months between time1 and time2. time1 and time2
are expressed in
> * microseconds since 1.1.1970.
> *
> - * If time1 and time2 having the same day of month, or both are the
last day of month,
> - * it returns an integer (time under a day will be ignored).
> + * If time1 and time2 are on the same day of month, or both are the
last day of month,
> + * time of a day will be ignored.
> + *
> + * Otherwise, the difference is calculated based on 31 days per month,
and rounded to
> + * 8 digits.
> + */
> + def monthsBetween(time1: SQLTimestamp, time2: SQLTimestamp): Double = {
>
> From a very quick look. there was a mistake when merging it in. @aditkumar
> <https://github.com/aditkumar>, mind if I ask to rebase and sync it
> please?
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/spark/pull/20787#pullrequestreview-117477421>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/ABee_84UZDHyqyEmNtyYe_MuC2i4Ee1lks5tu688gaJpZM4SkgK->
> .
>
--
Adit Kumar (US) +1 (201)-566-8630 (UK) +44 7415 930329 Sent via mobile
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
