Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/21195#discussion_r185971647 --- Diff: mllib/src/test/scala/org/apache/spark/ml/clustering/BisectingKMeansSuite.scala --- @@ -182,6 +184,40 @@ class BisectingKMeansSuite model.clusterCenters.forall(Vectors.norm(_, 2) == 1.0) } + + test("BisectingKMeans with Array input") { + val featuresColNameD = "array_double_features" + val featuresColNameF = "array_float_features" + val doubleUDF = udf { (features: Vector) => + val featureArray = Array.fill[Double](features.size)(0.0) + features.foreachActive((idx, value) => featureArray(idx) = value.toFloat) --- End diff -- * If `.toFloat` is to keep the same precision, we should leave an inline comment. * `features.toArray.map(_.toFloat.toDouble)` should do the work.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org