Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21122#discussion_r186214427
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1354,7 +1354,8 @@ class HiveDDLSuite
val indexName = tabName + "_index"
withTable(tabName) {
// Spark SQL does not support creating index. Thus, we have to use
Hive client.
- val client =
spark.sharedState.externalCatalog.asInstanceOf[HiveExternalCatalog].client
+ val client =
+
spark.sharedState.externalCatalog.unwrapped.asInstanceOf[HiveExternalCatalog].client
--- End diff --
The client is used for interacting with Hive metastore. Conceptually, it
should be part of `HiveExternalCatalog`. If we want to pass it as a field of
HiveExternalCatalog , we need to create the client in SharedState, which is in
the core module instead of the hive module. Since we are getting rid of Hive
from the code base, we do not want a Hive-speicific SharedState. Any better
idea?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
