Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186263241
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -64,7 +64,7 @@ case class CreateArray(children: Seq[Expression]) extends
Expression {
val (preprocess, assigns, postprocess, arrayData) =
GenArrayData.genCodeToCreateArrayData(ctx, et, evals, false)
ev.copy(
- code = JavaCode.block(preprocess + assigns + postprocess),
+ code = code"$preprocess" + code"$assigns" + code"$postprocess",
--- End diff --
nit: can this be `code"${preprocess}${assigns}${postprocess}"`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
