Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21182#discussion_r186264859
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -136,4 +136,6 @@ private[sql] class JSONOptions(
allowBackslashEscapingAnyCharacter)
factory.configure(JsonParser.Feature.ALLOW_UNQUOTED_CONTROL_CHARS,
allowUnquotedControlChars)
}
+
+ @transient val textOptions = parameters
--- End diff --
My motivation for creating of the separate variable for text parameters was
having one place where the text parameters are forming. So, in the future if we
need additional options to pass to the Text datasource, don't need to modify
all places where they are forming. @viirya If you believe, it over-complicates
the implementation, I will remove it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
