GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/21250
[SPARK-23291][SQL][R][BRANCH-2.3] R's substr should not reduce starting
position by 1 when calling Scala API
## What changes were proposed in this pull request?
This PR backports
https://github.com/apache/spark/commit/24b5c69ee3feded439e5bb6390e4b63f503eeafe
and https://github.com/apache/spark/pull/21249
There's no conflict but I opened this just to run the test and for sure.
## How was this patch tested?
Jenkins tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark SPARK-23291-backport
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21250.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21250
----
commit 24b5c69ee3feded439e5bb6390e4b63f503eeafe
Author: Liang-Chi Hsieh <viirya@...>
Date: 2018-03-07T17:37:42Z
[SPARK-23291][SQL][R] R's substr should not reduce starting position by 1
when calling Scala API
## What changes were proposed in this pull request?
Seems R's substr API treats Scala substr API as zero based and so subtracts
the given starting position by 1.
Because Scala's substr API also accepts zero-based starting position
(treated as the first element), so the current R's substr test results are
correct as they all use 1 as starting positions.
## How was this patch tested?
Modified tests.
Author: Liang-Chi Hsieh <vii...@gmail.com>
Closes #20464 from viirya/SPARK-23291.
commit ffd4c7b05b0425090fd97bc0764b7e0f5918348c
Author: hyukjinkwon <gurwls223@...>
Date: 2018-05-06T08:56:02Z
Update SparkR migration note for SPARK-23291
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
