Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/21066#discussion_r186469794 --- Diff: hadoop-cloud/src/hadoop-3/main/scala/org/apache/spark/internal/io/cloud/BindingParquetOutputCommitter.scala --- @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.internal.io.cloud + +import java.io.IOException + +import org.apache.hadoop.fs.Path +import org.apache.hadoop.mapreduce.lib.output.{BindingPathOutputCommitter, PathOutputCommitter} +import org.apache.hadoop.mapreduce.{JobContext, JobStatus, TaskAttemptContext} +import org.apache.parquet.hadoop.ParquetOutputCommitter + +import org.apache.spark.internal.Logging + + +/** + * This dynamically binds to the factory-configured + * output committer, and is intended to allow callers to use any [[PathOutputCommitter]], + * even if not a subclass of [[ParquetOutputCommitter]]. + * + * The Parquet "parquet.enable.summary-metadata" option will only be supported + * if the instantiated committer itself supports it. + */ + --- End diff -- done
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org