Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21240#discussion_r186663298
  
    --- Diff: 
sql/core/src/test/resources/sql-tests/inputs/udtf_replicate_rows.sql ---
    @@ -0,0 +1,41 @@
    +CREATE TEMPORARY VIEW tab1 AS SELECT * FROM VALUES
    +    (1, 'row1', 1.1), 
    +    (2, 'row2', 2.2),
    +    (0, 'row3', 3.3),
    +    (-1,'row4', 4.4),
    +    (null,'row5', 5.5),
    +    (3, 'row6', null)
    +    AS tab1(c1, c2, c3);
    +
    +-- Requires 2 arguments at minimum.
    +SELECT replicate_rows() FROM tab1;
    +
    +-- Requires 2 arguments at minimum.
    +SELECT replicate_rows(c1) FROM tab1;
    +
    +-- First argument should be a numeric type.
    --- End diff --
    
    nit: I think `numeric` generally includes float and double, too.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to