Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186793604
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -44,11 +44,16 @@ private[spark] class BasicDriverFeatureStep(
private val driverCpuCores = conf.get("spark.driver.cores", "1")
private val driverLimitCores = conf.get(KUBERNETES_DRIVER_LIMIT_CORES)
+ private val driverDockerContainer =
conf.roleSpecificConf.mainAppResource.map {
+ case JavaMainAppResource(_) => "driver"
+ case PythonMainAppResource(_) => "driver-py"
+ }.getOrElse(throw new SparkException("Must specify a JVM or Python
Resource"))
--- End diff --
Should I therefore not throw an error here @mccheah and move this logic
into the steps?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
