Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21028#discussion_r187233292
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
 ---
    @@ -529,6 +564,272 @@ case class ArrayContains(left: Expression, right: 
Expression)
       override def prettyName: String = "array_contains"
     }
     
    +/**
    + * Checks if the two arrays contain at least one common element.
    + */
    +// scalastyle:off line.size.limit
    +@ExpressionDescription(
    +  usage = "_FUNC_(a1, a2) - Returns true if a1 contains at least an 
element present also in a2. If the arrays have no common element and either of 
them contains a null element null is returned, false otherwise.",
    +  examples = """
    +    Examples:
    +      > SELECT _FUNC_(array(1, 2, 3), array(3, 4, 5));
    +       true
    +  """, since = "2.4.0")
    +// scalastyle:off line.size.limit
    +case class ArraysOverlap(left: Expression, right: Expression)
    +  extends BinaryArrayExpressionWithImplicitCast {
    +
    +  override def checkInputDataTypes(): TypeCheckResult = 
super.checkInputDataTypes() match {
    +    case TypeCheckResult.TypeCheckSuccess =>
    +      if (RowOrdering.isOrderable(elementType)) {
    +        TypeCheckResult.TypeCheckSuccess
    +      } else {
    +        TypeCheckResult.TypeCheckFailure(s"${elementType.simpleString} 
cannot be used in comparison.")
    +      }
    +    case failure => failure
    +  }
    +
    +  @transient private lazy val ordering: Ordering[Any] =
    +    TypeUtils.getInterpretedOrdering(elementType)
    +
    +  @transient private lazy val elementTypeSupportEquals = elementType match 
{
    +    case BinaryType => false
    +    case _: AtomicType => true
    +    case _ => false
    +  }
    +
    +  @transient private lazy val doEvaluation = if (elementTypeSupportEquals) 
{
    +      fastEval _
    +    } else {
    +      bruteForceEval _
    +    }
    --- End diff --
    
    nit: indent


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to