Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21291#discussion_r187489196
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
 ---
    @@ -345,6 +345,16 @@ case class RangeExec(range: 
org.apache.spark.sql.catalyst.plans.logical.Range)
     
       override val output: Seq[Attribute] = range.output
     
    +  override def outputOrdering: Seq[SortOrder] = range.outputOrdering
    +
    +  override def outputPartitioning: Partitioning = {
    +    if (numSlices == 1) {
    +      SinglePartition
    --- End diff --
    
    Which one is better? `SinglePartition` or 
`RangePartitioning(outputOrdering, 1)`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to