Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21296#discussion_r187500240
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
 ---
    @@ -267,7 +267,7 @@ class CSVSuite extends QueryTest with SharedSQLContext 
with SQLTestUtils with Te
             .options(Map("header" -> "true", "mode" -> "dropmalformed"))
             .load(testFile(carsFile))
     
    -      assert(cars.select("year").collect().size === 2)
    +      assert(cars.collect().size === 2)
    --- End diff --
    
    This changes behaviour and it's intendedly parsed to keep the backword 
compatibility. There was an issue about the different number of counts. I think 
you are basically saying `cars.select("year").collect().size` and 
`cars.collect().size` are different and they are correct, right?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to