Github user edwinalu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21221#discussion_r187501157
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -1753,9 +1766,21 @@ class DAGScheduler(
         messageScheduler.shutdownNow()
         eventProcessLoop.stop()
         taskScheduler.stop()
    +    heartbeater.stop()
    +  }
    +
    +  /** Reports heartbeat metrics for the driver. */
    +  private def reportHeartBeat(): Unit = {
    --- End diff --
    
    With cluster mode, including YARN, there isn't a local executor, so the 
metrics for the driver would not be collected. Perhaps this could be modified 
to skip this step for local mode.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to