Github user xuanyuanking commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21293#discussion_r187596748
  
    --- Diff: core/src/main/scala/org/apache/spark/Dependency.scala ---
    @@ -65,15 +65,17 @@ abstract class NarrowDependency[T](_rdd: RDD[T]) 
extends Dependency[T] {
      * @param keyOrdering key ordering for RDD's shuffles
      * @param aggregator map/reduce-side aggregator for RDD's shuffle
      * @param mapSideCombine whether to perform partial aggregation (also 
known as map-side combine)
    + * @param isContinuous mark the dependency is base for continuous 
processing or not
    --- End diff --
    
    Actually we can implement ContinuousShuffleDependency by inheriting 
Dependency. In current way few interface can be changed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to