Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21054#discussion_r187761743
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
    @@ -775,6 +775,178 @@ object functions {
        */
       def var_pop(columnName: String): Column = var_pop(Column(columnName))
     
    +  /**
    +   * Aggregate function: returns the number of non-null pairs.
    +   *
    +   * @group agg_funcs
    +   * @since 2.4.0
    +   */
    +  def regr_count(y: Column, x: Column): Column = withAggregateFunction {
    --- End diff --
    
    @rxin, how about splitting up this file by the group or something, or 
deprecating all the functions that can be called via expr for 3.0.0? To me, it 
looked a bit odd when some functions exist and some did not. It was an actual 
use case and I had to check which function exists or not every time.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to