Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21314#discussion_r187815502 --- Diff: R/pkg/R/client.R --- @@ -82,7 +82,7 @@ checkJavaVersion <- function() { }) javaVersionFilter <- Filter( function(x) { - grepl("java version", x) + grepl(" version", x) --- End diff -- right, I debated about it. I think we should grep for the longest match as much as possible but I suppose the space is too common to be meaningful, so I don't feel strongly either way
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org