Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21257#discussion_r188186699
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala ---
@@ -120,7 +120,8 @@ abstract class FileCommitProtocol {
* Specifies that a file should be deleted with the commit of this job.
The default
* implementation deletes the file immediately.
*/
- def deleteWithJob(fs: FileSystem, path: Path, recursive: Boolean):
Boolean = {
+ def deleteWithJob(fs: FileSystem, path: Path, recursive: Boolean,
--- End diff --
Is there any (potential) cases we need a `recursive` parameter?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
