Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21106#discussion_r188872456
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverterSuite.scala
---
@@ -24,21 +24,27 @@ import org.scalatest.Matchers
import org.apache.spark.SparkFunSuite
import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.plans.PlanTestBase
import org.apache.spark.sql.catalyst.util._
+import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types.{IntegerType, LongType, _}
import org.apache.spark.unsafe.array.ByteArrayMethods
import org.apache.spark.unsafe.types.UTF8String
-class UnsafeRowConverterSuite extends SparkFunSuite with Matchers {
+class UnsafeRowConverterSuite extends SparkFunSuite with Matchers with
PlanTestBase {
private def roundedSize(size: Int) =
ByteArrayMethods.roundNumberOfBytesToNearestWord(size)
private def testWithFactory(
--- End diff --
we can also clean this up
```
def testBothCodegenAndInterpreted(name: String, f: => Unit): Unit = {
for (fallbackMode <- Seq(CodegenObjectFactoryMode.CODEGEN_ONLY, ...)) {
test(name + " with " + fallbackMode) {
withSQLConf ...
}
}
}
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
