Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21291#discussion_r189151725
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -55,7 +55,9 @@ class WholeStageCodegenSuite extends QueryTest with
SharedSQLContext {
val plan = df.queryExecution.executedPlan
assert(plan.find(p =>
p.isInstanceOf[WholeStageCodegenExec] &&
-
p.asInstanceOf[WholeStageCodegenExec].child.isInstanceOf[HashAggregateExec]).isDefined)
+ p.asInstanceOf[WholeStageCodegenExec].child.collect {
--- End diff --
same here, can we change the `groupBy` instead of the test?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
