GitHub user rednaxelafx opened a pull request:
https://github.com/apache/spark/pull/21367
[SPARK-24321][SQL] Extract common code from Divide/Remainder to a base trait
## What changes were proposed in this pull request?
Extract common code from `Divide`/`Remainder` to a new base trait,
`DivModLike`.
Further refactoring to make `Pmod` work with `DivModLike` is to be done as
a separate task.
## How was this patch tested?
Existing tests in `ArithmeticExpressionSuite` covers the functionality.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rednaxelafx/apache-spark catalyst-divmod
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21367.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21367
----
commit 026531c70bfb7e06f8586010fc48a8666ff4df04
Author: Kris Mok <kris.mok@...>
Date: 2018-05-18T21:50:50Z
SPARK-24321: Extract common code from Divide/Remainder to a base trait
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
