Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21361#discussion_r189429011
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
 ---
    @@ -134,6 +134,32 @@ class CollectionExpressionsSuite extends SparkFunSuite 
with ExpressionEvalHelper
     
         checkEvaluation(ArrayContains(a3, Literal("")), null)
         checkEvaluation(ArrayContains(a3, Literal.create(null, StringType)), 
null)
    +
    +    // complex data types
    +    val b0 = Literal.create(Seq[Array[Byte]](Array[Byte](5, 6), 
Array[Byte](1, 2)),
    +      ArrayType(BinaryType))
    +    val b1 = Literal.create(Seq[Array[Byte]](Array[Byte](2, 1), 
Array[Byte](4, 3)),
    +      ArrayType(BinaryType))
    +    val b2 = Literal.create(Seq[Array[Byte]](Array[Byte](2, 1), null),
    +      ArrayType(BinaryType))
    +    val b3 = Literal.create(Seq[Array[Byte]](null, Array[Byte](1, 2)),
    +      ArrayType(BinaryType))
    +    val be = Literal.create(Array[Byte](1, 2), BinaryType)
    --- End diff --
    
    ditto, binary type is not complex type


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to