Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21371#discussion_r189446146
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/internal/ExecutorSideSQLConfSuite.scala
 ---
    @@ -59,7 +59,8 @@ class ExecutorSideSQLConfSuite extends SparkFunSuite with 
SQLTestUtils {
             val pathString = path.getCanonicalPath
             spark.range(10).select('id.as("ID")).write.json(pathString)
             spark.range(10).write.mode("append").json(pathString)
    -        assert(spark.read.json(pathString).columns.toSet == Set("id", 
"ID"))
    +        val df = spark.read.option("samplingRatio", 1).json(pathString)
    --- End diff --
    
    oh, I just found `samplingRatio` is 1.0 by default. The flaky test should 
not because of this.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to