Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21370#discussion_r189447465
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -237,9 +236,13 @@ class Dataset[T] private[sql](
* @param truncate If set to more than 0, truncates strings to
`truncate` characters and
* all cells will be aligned right.
* @param vertical If set to true, prints output rows vertically (one
line per column value).
+ * @param html If set to true, return output as html table.
*/
private[sql] def showString(
- _numRows: Int, truncate: Int = 20, vertical: Boolean = false):
String = {
+ _numRows: Int,
+ truncate: Int = 20,
--- End diff --
when the output is truncated, does jupyter handle that properly?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
