Github user sergey-rubtsov commented on a diff in the pull request:
https://github.com/apache/spark/pull/21363#discussion_r189582909
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchemaSuite.scala
---
@@ -59,13 +59,21 @@ class CSVInferSchemaSuite extends SparkFunSuite {
assert(CSVInferSchema.inferField(IntegerType, textValueOne, options)
== expectedTypeOne)
}
- test("Timestamp field types are inferred correctly via custom data
format") {
- var options = new CSVOptions(Map("timestampFormat" -> "yyyy-mm"),
"GMT")
+ test("Timestamp field types are inferred correctly via custom date
format") {
+ var options = new CSVOptions(Map("timestampFormat" -> "yyyy-MM"),
"GMT")
--- End diff --
"yyyy-mm" means years and minutes, this is date format, this is time format
yyyy-MM" means years and months, but I do not insist on this change
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
