Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21356#discussion_r189604443
--- Diff: core/src/main/scala/org/apache/spark/util/ListenerBus.scala ---
@@ -80,7 +89,16 @@ private[spark] trait ListenerBus[L <: AnyRef, E] extends
Logging {
}
try {
doPostEvent(listener, event)
+ if (Thread.interrupted()) {
+ logError(s"Interrupted while posting to
${Utils.getFormattedClassName(listener)}. " +
+ s"Removing that listener.")
+ removeListenerOnError(listener)
--- End diff --
`Thread.interrupted()` also clears the interrupted state. So that alone
isn't a problem -- we're basically declaring that we've handled the interrupt
and nobody else gets to know about it anymore.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
