Github user erikerlandson commented on a diff in the pull request: https://github.com/apache/spark/pull/21366#discussion_r189735073 --- Diff: pom.xml --- @@ -150,6 +150,7 @@ <!-- org.apache.httpcomponents/httpclient--> <commons.httpclient.version>4.5.4</commons.httpclient.version> <commons.httpcore.version>4.4.8</commons.httpcore.version> + <trove.version>3.0.1</trove.version> --- End diff -- My take is that the performance is probably not worth the additional dependency. I also noticed that the trove dep is LGPL, which is considered incompatible with Apache license. Although I believe this is not a show-stopper with respect to "containerized" dependencies, it probably is for a direct dependency in the code.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org