Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21380#discussion_r189759999
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/UnivocityParser.scala
 ---
    @@ -300,14 +302,11 @@ private[csv] object UnivocityParser {
           lines
         }
     
    -    val filteredLines: Iterator[String] =
    -      CSVUtils.filterCommentAndEmpty(linesWithoutHeader, options)
    --- End diff --
    
    I feel sure I put this because Univocity has an issue about this before. 
Wouldn't we better just keep this just in case? I think we already do such 
things in Spark side redundantly to make sure.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to