Github user galv commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r190107502
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
---
@@ -306,9 +318,14 @@ private[yarn] class YarnAllocator(
s"executorsStarting: ${numExecutorsStarting.get}")
if (missing > 0) {
- logInfo(s"Will request $missing executor container(s), each with " +
- s"${resource.getVirtualCores} core(s) and " +
- s"${resource.getMemory} MB memory (including $memoryOverhead MB of
overhead)")
+ var requestContainerMessage = s"Will request $missing executor
container(s), each with " +
+ s"${resource.getVirtualCores} core(s) and " +
+ s"${resource.getMemory} MB memory (including $memoryOverhead MB
of overhead) "
+ if (ResourceTypeHelper.isYarnResourceTypesAvailable()) {
+ requestContainerMessage ++= s"and with custom resources:" +
+ ResourceTypeHelper.getCustomResourcesAsStrings(resource)
--- End diff --
I think you should check for the message being an empty string, so you
don't confusingly put just `s"and with custom resources:"`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
