Github user jose-torres commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21392#discussion_r190112179
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/EpochCoordinator.scala
 ---
    @@ -45,6 +45,11 @@ private[sql] case object IncrementAndGetEpoch extends 
EpochCoordinatorMessage
      */
     private[sql] case object StopContinuousExecutionWrites extends 
EpochCoordinatorMessage
     
    +/**
    + * Returns boolean indicating if size of the epochs queue has exceeded 
maximum epoch backlog.
    + */
    +private[sql] case object CheckIfMaxBacklogIsExceeded extends 
EpochCoordinatorMessage
    --- End diff --
    
    I'm not sure we need to make a side-channel in the RPC handler for this. 
I'd try to just make the query fail when the condition is reached in the first 
place.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to