Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21082#discussion_r190176898
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ---
    @@ -1869,6 +1870,8 @@ class Analyzer(
               case window: WindowExpression => window.windowSpec
             }.distinct
     
    +        val windowFunctionType = WindowFunctionType.functionType(expr)
    --- End diff --
    
    Yeah, I can see it is included in the tuple, but seems like it is used for 
nothing after that and dropped at 
https://github.com/apache/spark/pull/21082/files#diff-57b3d87be744b7d79a9beacf8e5e5eb2R1886?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to