Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21372#discussion_r190383386
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
 ---
    @@ -169,6 +170,14 @@ abstract class OrcSuite extends OrcTest with 
BeforeAndAfterAll {
           }
         }
       }
    +
    +  test("SPARK-24322 Fix incorrect workaround for bug in 
java.sql.Timestamp") {
    +    withTempPath { path =>
    +      val ts = Timestamp.valueOf("1900-05-05 12:34:56.000789")
    +      Seq(ts).toDF.write.orc(path.getCanonicalPath)
    +      checkAnswer(spark.read.orc(path.getCanonicalPath), Row(ts))
    +    }
    +  }
    --- End diff --
    
    `OrcSourceSuite` is dedicated for `native` Orc Reader . For `hive` ORC 
reader, `HiveOrcSourceSuite`. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to