Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2964#discussion_r19636020
  
    --- Diff: docs/configuration.md ---
    @@ -21,16 +21,19 @@ application. These properties can be set directly on a
     [SparkConf](api/scala/index.html#org.apache.spark.SparkConf) passed to your
     `SparkContext`. `SparkConf` allows you to configure some of the common 
properties
     (e.g. master URL and application name), as well as arbitrary key-value 
pairs through the
    -`set()` method. For example, we could initialize an application as follows:
    +`set()` method. For example, we could initialize an application with one 
worker as follows:
     
     {% highlight scala %}
     val conf = new SparkConf()
    -             .setMaster("local")
    +             .setMaster("local[1]")
    --- End diff --
    
    I actually though the default behavior of `local` was 2 threads, but in the 
code I don't think that's true. I thought @mateiz mentioned one time that it's 
better to run with minimal parallelism by default to expose issues that might 
only appear when there are multiple executors.
    
    In any event, given that, and the thrust of this doc change, is it good to 
encourage people to use 1 worker? how about explicitly 2? Making it explicit is 
a small good thing anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to