Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/21369
  
    the patch LGTM, but I'm not sure the test is useful. it's too coupled with 
the implementation and if we have reference leak again, I don't think the test 
can help to detect it.
    
    Can we copy-paste 
https://github.com/scala/scala/blob/2.13.x/test/junit/scala/tools/testing/AssertUtil.scala#L69-L90
 to the test?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to