Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21361#discussion_r191065107
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -582,11 +585,7 @@ case class ArraysOverlap(left: Expression, right:
Expression)
override def checkInputDataTypes(): TypeCheckResult =
super.checkInputDataTypes() match {
case TypeCheckResult.TypeCheckSuccess =>
- if (RowOrdering.isOrderable(elementType)) {
- TypeCheckResult.TypeCheckSuccess
- } else {
- TypeCheckResult.TypeCheckFailure(s"${elementType.simpleString}
cannot be used in comparison.")
- }
+ TypeUtils.checkForOrderingExpr(elementType, s"function $prettyName")
--- End diff --
Also a general suggestion. For these refactoring, we should do it in a
separate PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
