Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21434#discussion_r191090953 --- Diff: R/pkg/R/functions.R --- @@ -3062,6 +3077,21 @@ setMethod("array_sort", column(jc) }) +#' @details +#' \code{arrays_overlap}: Returns true if the input arrays have at least one non-null element in +#' common. If not and both arrays are non-empty and any of them contains a null, it returns null. +#' It returns false otherwise. +#' +#' @rdname column_collection_functions +#' @aliases arrays_overlap arrays_overlap,Column-method +#' @note arrays_overlap since 2.4.0 +setMethod("arrays_overlap", + signature(y = "Column", x = "Column"), --- End diff -- right, I don't know why they were (y, x) either. for some (one?) it was to match existing parameter names (like `atan2`), and then it sticks. I think we should first - name the first column `x`, second - stay close to the parameter name in Scala for everything else.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org