Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21317#discussion_r191092872
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/SecretEnvUtils.scala
---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.deploy.k8s
+
+import scala.collection.JavaConverters._
+
+import io.fabric8.kubernetes.api.model.Container
+
+private[spark] object SecretEnvUtils {
+
+ def containerHasEnvVar(container: Container, envVarName: String):
Boolean = {
--- End diff --
Ok will fix. Guys I have one thing that worries me. Yaml allows to pass as
characters even the reserved ones. So if the name for the secret had a
character like `:` character then we cant handle this right now. In yaml that
would be escaped or we could use double quotes. Here we dont have that logic
correct? Is it ok not to have the same level of expressiveness? At the end of
the day yaml seems close to k8s and I was wondering why we dont just specify
all properties for pods (driver & executor) in the yaml format read it and set
everyting via that method.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
