Github user ssuchter commented on the issue:

    https://github.com/apache/spark/pull/20697
  
    I'll work on Matt's comments from Friday next.
    
    Here's the output (after the bugfix) from running against mainline:
    
    ```
    MBP:~/src/ssuchter-spark% git remote get-url origin
    https://github.com/ssuchter/spark.git
    
    MBP:~/src/ssuchter-spark% git remote get-url upstream
    git://github.com/apache/spark.git
    
    1d8a265d13 (HEAD -> ssuchter-k8s-integration-tests, 
origin/ssuchter-k8s-integration-tests) Fix a bug in KubernetesTestComponents - 
don't an an empty string for zero arguments
    65347b319a Merge branch 'ssuchter-k8s-integration-tests' of 
https://github.com/ssuchter/spark into ssuchter-k8s-integration-tests
    1a531abcf6 Remove unused code relating to Kerberos, which doesn't belong in 
this PR
    3ba6ffb5f2 Remove e2e-prow.sh, which isn't appropriate for this PR
    9e64f43b62 Remove unnecessary cloning and building code for the Spark repo
    e6bd56325d Update README.md excluding cloning and building logic
    e70f3bea3d Remove K8s cloud-based backend testing support from this PR
    a0023b2f33 Remove config options that were only used during repo clone 
process
    e55b8a723e Remove repository cloning behavior and allow script to be called 
from other directories
    9b0eede244 Fixes for scala style
    f29679ef56 Ignore dist/ for style checks
    3615953bea Fix scala style issues
    bef586f740 Remove LICENSE and copy of mvn wrapper script. Rewrite path for 
calling mvn wrapper script.
    81c7a66ad6 Make k8s integration tests build when top-level kubernetes 
profile selected
    365d6bc65d Initial checkin of k8s integration tests. These tests were 
developed in the https://github.com/apache-spark-on-k8s/spark-integration repo 
by several contributors. This is a copy of the current state into the main 
apache spark repo. The only changes from the current spark-integration repo 
state are: * Move the files from the repo root into 
resource-managers/kubernetes/integration-tests * Add a reference to these tests 
in the root README.md * Fix a path reference in 
dev/dev-run-integration-tests.sh * Add a TODO in include/util.sh
    dbce275784 Remove unused code relating to Kerberos, which doesn't belong in 
this PR
    5ffa464c65 Remove e2e-prow.sh, which isn't appropriate for this PR
    13721f69a2 Remove unnecessary cloning and building code for the Spark repo
    ba720733fa Update README.md excluding cloning and building logic
    1b1528a504 (upstream/master, origin/master, origin/HEAD, master) 
[SPARK-24366][SQL] Improving of error messages for type converting
    
    MBP:~/src/ssuchter-spark% echo $REVISION
    1d8a265d13
    MBP:~/src/ssuchter-spark% echo $DATE
    20180528
    
    MBP:~/src/ssuchter-spark% ./dev/make-distribution.sh --name 
${DATE}-${REVISION} --tgz -DzincPort=${ZINC_PORT} -Phadoop-2.7 -Pkubernetes 
-Pkinesis-asl -Phive -Phive-thriftserver
    +++ dirname ./dev/make-distribution.sh
    ++ cd ./dev/..
    ++ pwd
    + SPARK_HOME=/Users/ssuchter/src/ssuchter-spark
    + DISTDIR=/Users/ssuchter/src/ssuchter-spark/dist
    + MAKE_TGZ=false
    + MAKE_PIP=false
    + MAKE_R=false
    …
    + TARDIR_NAME=spark-2.4.0-SNAPSHOT-bin-20180528-1d8a265d13
    + 
TARDIR=/Users/ssuchter/src/ssuchter-spark/spark-2.4.0-SNAPSHOT-bin-20180528-1d8a265d13
    + rm -rf 
/Users/ssuchter/src/ssuchter-spark/spark-2.4.0-SNAPSHOT-bin-20180528-1d8a265d13
    + cp -r /Users/ssuchter/src/ssuchter-spark/dist 
/Users/ssuchter/src/ssuchter-spark/spark-2.4.0-SNAPSHOT-bin-20180528-1d8a265d13
    + tar czf spark-2.4.0-SNAPSHOT-bin-20180528-1d8a265d13.tgz -C 
/Users/ssuchter/src/ssuchter-spark spark-2.4.0-SNAPSHOT-bin-20180528-1d8a265d13
    + rm -rf 
/Users/ssuchter/src/ssuchter-spark/spark-2.4.0-SNAPSHOT-bin-20180528-1d8a265d13
    
    MBP:~/src/ssuchter-spark% 
./resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
 --spark-tgz 
~/src/ssuchter-spark/spark-2.4.0-SNAPSHOT-bin-20180528-1d8a265d13.tgz
    Using `mvn` from path: /usr/local/bin/mvn
    [INFO] Scanning for projects...
    [INFO]
    [INFO] 
------------------------------------------------------------------------
    [INFO] Building Spark Project Kubernetes Integration Tests 2.4.0-SNAPSHOT
    [INFO] 
------------------------------------------------------------------------
    [INFO]
    [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-versions) @ 
spark-kubernetes-integration-tests_2.11 ---
    …
    Successfully tagged kubespark/spark:68388D3B-6FAC-4E59-8AED-8604AA437C2D
    
/Users/ssuchter/src/ssuchter-spark/resource-managers/kubernetes/integration-tests
    [INFO]
    [INFO] --- scalatest-maven-plugin:1.0:test (integration-test) @ 
spark-kubernetes-integration-tests_2.11 ---
    Discovery starting.
    Discovery completed in 118 milliseconds.
    Run starting. Expected test count is: 1
    KubernetesSuite:
    - Run SparkPi with no resources
    Run completed in 54 seconds, 202 milliseconds.
    Total number of tests run: 1
    Suites: completed 2, aborted 0
    Tests: succeeded 1, failed 0, canceled 0, ignored 0, pending 0
    All tests passed.
    [INFO] 
------------------------------------------------------------------------
    [INFO] BUILD SUCCESS
    [INFO] 
------------------------------------------------------------------------
    [INFO] Total time: 02:40 min
    [INFO] Finished at: 2018-05-28T20:21:28-07:00
    [INFO] Final Memory: 37M/470M
    [INFO] 
------------------------------------------------------------------------
    
    ```
    
    



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to