Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21437#discussion_r191589537
  
    --- Diff: python/pyspark/taskcontext.py ---
    @@ -88,3 +89,9 @@ def taskAttemptId(self):
             TaskAttemptID.
             """
             return self._taskAttemptId
    +
    +    def getLocalProperty(self, key):
    +        """
    +        Get a local property set upstream in the driver, or None if it is 
missing.
    --- End diff --
    
    If it's missing it will result in a `KeyError`, maybe you want `return 
self._localProperties.get(key)` which returns `None` as the default?  That 
seems better to me too, although you might want to add an optional `default` 
value.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to