Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21247#discussion_r191831524
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2313,25 +2314,6 @@ class JsonSuite extends QueryTest with
SharedSQLContext with TestJsonData {
}
}
- test("SPARK-23723: write json in UTF-16/32 with multiline off") {
- Seq("UTF-16", "UTF-32").foreach { encoding =>
- withTempPath { path =>
- val ds = spark.createDataset(Seq(
- ("a", 1), ("b", 2), ("c", 3))
- ).repartition(2)
- val e = intercept[IllegalArgumentException] {
- ds.write
- .option("encoding", encoding)
- .option("multiline", "false")
- .format("json").mode("overwrite")
- .save(path.getCanonicalPath)
- }.getMessage
- assert(e.contains(
- s"$encoding encoding in the blacklist is not allowed when
multiLine is disabled"))
--- End diff --
We can still keep this test case, right? We can change this negative test
case to positive test case
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
