Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/21346#discussion_r191976952 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/StreamData.java --- @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.network.server; + +import java.io.IOException; +import java.nio.ByteBuffer; + +import org.apache.spark.network.client.RpcResponseCallback; +import org.apache.spark.network.client.StreamCallback; +import org.apache.spark.network.client.StreamInterceptor; +import org.apache.spark.network.util.TransportFrameDecoder; + +/** + * A holder for streamed data sent along with an RPC message. + */ +public class StreamData { + + private final TransportRequestHandler handler; + private final TransportFrameDecoder frameDecoder; + private final RpcResponseCallback rpcCallback; + private final ByteBuffer meta; --- End diff -- whoops, you're right. I was using this at one point in the follow-on patch, then changed it and didn't fully clean this up. thanks
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org