Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21470#discussion_r192266617
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala ---
@@ -62,8 +62,9 @@ trait HashJoin {
}
protected lazy val (buildKeys, streamedKeys) = {
- require(leftKeys.map(_.dataType) == rightKeys.map(_.dataType),
- "Join keys from two sides should have same types")
+ require(leftKeys.map(_.dataType).zip(rightKeys.map(_.dataType)).forall
{
+ case (l, r) => BinaryOperator.sameType(l, r)
--- End diff --
Do we have a test case to cover this?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
